- Replace nav inline newsletter form with Subscribe CTA link per wireframe - Remove newsletter form from footer; add Connect section with social/RSS links - Fix honeypot inputs using hidden attribute (inline style blocked by CSP) - Add available_tags to HomePage.get_context for Explore Topics section - Add data-comment-form attribute to main comment form for reliable locating - Seed approved comment in E2E content for reply flow testing - Expand test_comments.py: moderation message, not-immediately-visible, missing fields, reply form visible, reply submission - Make COMMENT_RATE_LIMIT_PER_MINUTE configurable; set 100 in dev to prevent E2E test exhaustion; update rate limit unit test with override_settings - Update newsletter/home E2E tests to reflect nav form removal - Update unit test to assert no nav/footer newsletter forms Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
67 lines
3.0 KiB
Python
67 lines
3.0 KiB
Python
"""E2E tests for the newsletter subscription form."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from playwright.sync_api import Page, expect
|
|
|
|
|
|
def _nav_newsletter_form(page: Page):
|
|
"""Return the newsletter form in the home page sidebar aside."""
|
|
return page.locator("aside").locator("form[data-newsletter-form]").first
|
|
|
|
|
|
@pytest.mark.e2e
|
|
def test_subscribe_valid_email_shows_confirmation(page: Page, base_url: str) -> None:
|
|
page.goto(f"{base_url}/", wait_until="networkidle")
|
|
form = _nav_newsletter_form(page)
|
|
form.locator('input[type="email"]').fill("playwright-test@example.com")
|
|
form.get_by_role("button", name="Subscribe").click()
|
|
|
|
# JS sets the data-newsletter-message text on success
|
|
message = form.locator("[data-newsletter-message]")
|
|
expect(message).to_have_text("Check your email to confirm your subscription.", timeout=5_000)
|
|
|
|
|
|
@pytest.mark.e2e
|
|
def test_subscribe_invalid_email_shows_error(page: Page, base_url: str) -> None:
|
|
page.goto(f"{base_url}/", wait_until="networkidle")
|
|
form = _nav_newsletter_form(page)
|
|
# Disable the browser's native HTML5 email validation so the JS handler
|
|
# fires and sends the bad value to the server (which returns 400).
|
|
page.evaluate("document.querySelector('aside form[data-newsletter-form]').setAttribute('novalidate', '')")
|
|
form.locator('input[type="email"]').fill("not-an-email")
|
|
form.get_by_role("button", name="Subscribe").click()
|
|
|
|
message = form.locator("[data-newsletter-message]")
|
|
expect(message).to_have_text("Please enter a valid email.", timeout=5_000)
|
|
|
|
|
|
@pytest.mark.e2e
|
|
def test_subscribe_from_article_aside(page: Page, base_url: str) -> None:
|
|
"""Newsletter form embedded in the article aside also works."""
|
|
page.goto(f"{base_url}/articles/nightly-playwright-journey/", wait_until="networkidle")
|
|
aside_form = page.locator("aside").locator("form[data-newsletter-form]")
|
|
aside_form.locator('input[type="email"]').fill("aside-test@example.com")
|
|
aside_form.get_by_role("button", name="Subscribe").click()
|
|
|
|
message = aside_form.locator("[data-newsletter-message]")
|
|
expect(message).to_have_text("Check your email to confirm your subscription.", timeout=5_000)
|
|
|
|
|
|
@pytest.mark.e2e
|
|
def test_subscribe_duplicate_email_still_shows_confirmation(page: Page, base_url: str) -> None:
|
|
"""Submitting the same address twice must not expose an error to the user."""
|
|
email = "dupe-e2e@example.com"
|
|
page.goto(f"{base_url}/", wait_until="networkidle")
|
|
form = _nav_newsletter_form(page)
|
|
form.locator('input[type="email"]').fill(email)
|
|
form.get_by_role("button", name="Subscribe").click()
|
|
message = form.locator("[data-newsletter-message]")
|
|
expect(message).to_have_text("Check your email to confirm your subscription.", timeout=5_000)
|
|
|
|
# Second submission — form resets after first, so fill again
|
|
form.locator('input[type="email"]').fill(email)
|
|
form.get_by_role("button", name="Subscribe").click()
|
|
expect(message).to_have_text("Check your email to confirm your subscription.", timeout=5_000)
|