nohype/main-site
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: nav/footer wireframe alignment, honeypot CSP fix, comment E2E coverage #22

Merged
mark merged 1 commits from fix/ui-cleanup into main 2026-03-01 12:35:21 +00:00
Conversation 0 Commits 1 Files Changed 14 +123 -48
codex_a commented 2026-03-01 12:18:34 +00:00
Owner
Copy Link

Summary

Bug fixes

  • Comment form broken: style="display:none" on honeypot inputs blocked by CSP style-src 'self', rendering them visible. Autofill triggering honeypot guard silently dropped comments. Fixed with HTML hidden attribute.
  • Nav/footer diverge from wireframe: Nav had inline newsletter form; footer had newsletter column. Fixed: nav = CTA Subscribe link; footer = Connect section with social/RSS links.
  • Explore Topics missing on home page: Added available_tags to HomePage.get_context.

E2E improvements

  • Expanded comment tests: moderation message, not-immediately-visible, missing fields, reply form, reply submission
  • Seeded approved comment for reply flow tests
  • COMMENT_RATE_LIMIT_PER_MINUTE configurable (100 in dev)
  • Updated home/newsletter E2E tests for nav form removal

38/38 E2E + all unit tests passing locally.

## Summary ### Bug fixes - **Comment form broken**: `style="display:none"` on honeypot inputs blocked by CSP `style-src 'self'`, rendering them visible. Autofill triggering honeypot guard silently dropped comments. Fixed with HTML `hidden` attribute. - **Nav/footer diverge from wireframe**: Nav had inline newsletter form; footer had newsletter column. Fixed: nav = CTA Subscribe link; footer = Connect section with social/RSS links. - **Explore Topics missing on home page**: Added `available_tags` to `HomePage.get_context`. ### E2E improvements - Expanded comment tests: moderation message, not-immediately-visible, missing fields, reply form, reply submission - Seeded approved comment for reply flow tests - `COMMENT_RATE_LIMIT_PER_MINUTE` configurable (100 in dev) - Updated home/newsletter E2E tests for nav form removal 38/38 E2E + all unit tests passing locally.
codex_a added 1 commit 2026-03-01 12:18:35 +00:00
fix: nav/footer wireframe, honeypot CSP, explore topics, comment E2E coverage
All checks were successful
CI / nightly-e2e (pull_request) Has been skipped
Details
CI / deploy (pull_request) Has been skipped
Details
CI / pr-e2e (pull_request) Successful in 1m11s
Details
CI / ci (pull_request) Successful in 1m25s
Details
155c8f7569 
- Replace nav inline newsletter form with Subscribe CTA link per wireframe
- Remove newsletter form from footer; add Connect section with social/RSS links
- Fix honeypot inputs using hidden attribute (inline style blocked by CSP)
- Add available_tags to HomePage.get_context for Explore Topics section
- Add data-comment-form attribute to main comment form for reliable locating
- Seed approved comment in E2E content for reply flow testing
- Expand test_comments.py: moderation message, not-immediately-visible,
  missing fields, reply form visible, reply submission
- Make COMMENT_RATE_LIMIT_PER_MINUTE configurable; set 100 in dev to prevent
  E2E test exhaustion; update rate limit unit test with override_settings
- Update newsletter/home E2E tests to reflect nav form removal
- Update unit test to assert no nav/footer newsletter forms

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mark merged commit c028a83bef into main 2026-03-01 12:35:21 +00:00
mark deleted branch fix/ui-cleanup 2026-03-01 12:35:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude codex_a codex_b codex_c mark
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nohype/main-site#22
Delete Branch "fix/ui-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?