nohype/main-site
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: redesign comments section for better UX/UI #45

Merged
mark merged 4 commits from feature/comments-design-makeover into main 2026-03-04 11:00:56 +00:00
Conversation 2 Commits 4 Files Changed 10 +176 -102
mark commented 2026-03-04 10:22:18 +00:00
Owner
Copy Link

This PR improves the comments section design:

  • Redesigned comment cards with better spacing and typography.
  • Clearer reply nesting with vertical line indicators.
  • Native details/summary toggle for reply forms.
  • More prominent 'Join the conversation' section.
  • Updated E2E tests to ensure compatibility.
This PR improves the comments section design: - Redesigned comment cards with better spacing and typography. - Clearer reply nesting with vertical line indicators. - Native details/summary toggle for reply forms. - More prominent 'Join the conversation' section. - Updated E2E tests to ensure compatibility.
mark added 1 commit 2026-03-04 10:22:18 +00:00
feat: redesign comments section for better UX/UI
Some checks failed
CI / nightly-e2e (pull_request) Has been skipped
Details
CI / deploy (pull_request) Has been skipped
Details
CI / pr-e2e (pull_request) Successful in 1m39s
Details
CI / ci (pull_request) Failing after 2m26s
Details
c47a62df5c 
- Redesigned comment cards with improved spacing and typography
- Added vertical line indicator for reply nesting
- Implemented native details/summary toggle for reply forms (replacing JS)
- Styled 'Join the conversation' section to be more distinct from existing comments
- Added solid-pink shadow to Tailwind configuration
- Updated E2E tests to match new UI structure and elements
mark force-pushed feature/comments-design-makeover from c47a62df5c to c8e01f5201 2026-03-04 10:28:34 +00:00 Compare
mark added 1 commit 2026-03-04 10:31:08 +00:00
chore: rebuild Tailwind CSS for comments redesign
All checks were successful
CI / nightly-e2e (pull_request) Has been skipped
Details
CI / deploy (pull_request) Has been skipped
Details
CI / pr-e2e (pull_request) Successful in 1m35s
Details
CI / ci (pull_request) Successful in 1m37s
Details
48f395866b
codex_a requested changes 2026-03-04 10:40:42 +00:00
Dismissed
codex_a left a comment
Owner
Copy Link

Blocking issues found:\n1) apps/comments/views.py:151 renders comments/_reply.html with context key 'comment', but templates/comments/_reply.html now expects 'reply'. Result: approved replies rendered via OOB are empty (id/author/body missing).\n2) apps/comments/views.py:153 targets '#comment-{parent_id} .replies-container' for OOB insertion, but templates/comments/_comment.html moved .replies-container outside the #comment-{id} article. Selector no longer matches, so approved replies are not appended inline.\n\nPlease fix both the context mismatch and OOB target mismatch, and add a test covering an immediately-approved reply render path.

Blocking issues found:\n1) apps/comments/views.py:151 renders comments/_reply.html with context key 'comment', but templates/comments/_reply.html now expects 'reply'. Result: approved replies rendered via OOB are empty (id/author/body missing).\n2) apps/comments/views.py:153 targets '#comment-{parent_id} .replies-container' for OOB insertion, but templates/comments/_comment.html moved .replies-container outside the #comment-{id} article. Selector no longer matches, so approved replies are not appended inline.\n\nPlease fix both the context mismatch and OOB target mismatch, and add a test covering an immediately-approved reply render path.
mark added 1 commit 2026-03-04 10:54:27 +00:00
fix: resolve review blockers for comments redesign
All checks were successful
CI / nightly-e2e (pull_request) Has been skipped
Details
CI / deploy (pull_request) Has been skipped
Details
CI / pr-e2e (pull_request) Successful in 1m36s
Details
CI / ci (pull_request) Successful in 1m38s
Details
b2ea693d9d 
- Fix context key mismatch in _render_htmx_success ('reply' vs 'comment')
- Update OOB swap selector to match new sibling relationship for replies container
- Update HTMX reply tests to verify correct OOB selector and content rendering
- Fix variable naming in _reply.html to match parent context
codex_a approved these changes 2026-03-04 10:58:20 +00:00
codex_a left a comment
Owner
Copy Link

Re-reviewed after latest fixes. Previous blockers are resolved:\n- Approved reply OOB render now passes correct 'reply' context to _reply.html.\n- OOB selector now targets the sibling .replies-container correctly.\nAlso verified with tests:\n- apps/comments/tests/test_v2.py::test_htmx_reply_returns_oob_reply_when_approved\n- apps/comments/tests + apps/blog/tests/test_views.py\n- python manage.py check\n\nNo further blocking issues found.

Re-reviewed after latest fixes. Previous blockers are resolved:\n- Approved reply OOB render now passes correct 'reply' context to _reply.html.\n- OOB selector now targets the sibling .replies-container correctly.\nAlso verified with tests:\n- apps/comments/tests/test_v2.py::test_htmx_reply_returns_oob_reply_when_approved\n- apps/comments/tests + apps/blog/tests/test_views.py\n- python manage.py check\n\nNo further blocking issues found.
mark merged commit 3ccb872cc3 into main 2026-03-04 11:00:56 +00:00
mark deleted branch feature/comments-design-makeover 2026-03-04 11:00:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
codex_a
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude codex_a codex_b codex_c mark
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nohype/main-site#45
Delete Branch "feature/comments-design-makeover"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?