codex_b

codex_b suggested changes for mark/thearchive#111

2026-03-13 15:45:00 +00:00

fix: mobile UX/UI fixes (issue #101)

Requesting changes after a strict QA pass against Issue #101 (excluding photo upload).

codex_b commented on pull request mark/thearchive#103

2026-03-13 00:02:55 +00:00

fix: harden photo uploads across forms

Per request, the e2e-photo-upload job remains in .gitea/workflows/pr-gate.yml but is now disabled by default with if: ${{ false }} so it does not run on every PR. It can be re-enabled later…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-13 00:02:36 +00:00

3e52a43fbb ci: disable photo upload slice by default

codex_b commented on pull request mark/thearchive#103

2026-03-12 23:45:52 +00:00

fix: harden photo uploads across forms

Added a dedicated e2e-photo-upload slice to PR Gate in 8c81e19.

It mirrors the existing containerized Playwright jobs, but runs tests/e2e/photo-formats.spec.ts as a focused CI gate for the…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 23:45:23 +00:00

8c81e198c5 ci: add photo upload e2e slice

codex_b commented on pull request mark/thearchive#103

2026-03-12 22:05:27 +00:00

fix: harden photo uploads across forms

Latest follow-up is pushed in e44a8c5.

This keeps the local Playwright harness on the safer default for the photo-validation path: when PLAYWRIGHT_BASE_URL is unset, the suite starts a fresh…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 22:05:15 +00:00

e44a8c5c0e test: default Playwright photo runs to fresh frontend

codex_b commented on pull request mark/thearchive#103

2026-03-12 21:35:14 +00:00

fix: harden photo uploads across forms

One more follow-up is pushed in 1a697ef to address the harness risks I found during the final review pass.

What changed:

frontend/playwright.config.ts now uses reuseExistingServer: true for…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 21:35:00 +00:00

1a697ef3fc test: harden Playwright local server handling

codex_b commented on pull request mark/thearchive#103

2026-03-12 21:32:32 +00:00

fix: harden photo uploads across forms

Follow-up for the latest review is pushed in 6182416.

The failing local reproduction turned out to be a Playwright harness problem rather than another photo-path logic bug: the photo-format spec…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 21:32:16 +00:00

6182416d1b test: make local Playwright runs self-contained

codex_b commented on pull request mark/thearchive#103

2026-03-12 20:27:59 +00:00

fix: harden photo uploads across forms

Resolved the two blockers in 02dcfb5.

Tightened normalizePhotoMimeType() so extension fallback only applies to empty MIME / application/octet-stream; misleading types like image/gif +…

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 20:27:40 +00:00

02dcfb5853 fix: cover photo upload edge cases

codex_b created pull request mark/thearchive#103

2026-03-12 17:29:25 +00:00

fix: harden photo uploads across forms

codex_b pushed to fix/issue-101-photo-upload-formats at mark/thearchive

2026-03-12 17:28:32 +00:00

c13c6151e6 fix: harden photo uploads across forms

codex_b created branch fix/issue-101-photo-upload-formats in mark/thearchive

2026-03-12 17:28:32 +00:00

codex_b opened issue mark/thearchive#100

2026-03-12 16:06:53 +00:00

Investigate: setup wizard restarts on refresh/deploy even though setup state should persist

codex_b approved mark/thearchive#96

2026-03-12 14:46:54 +00:00

fix: mobile UX improvements (#94)

Re-reviewed the latest update and I’m happy with this now.

codex_b suggested changes for mark/thearchive#96

2026-03-12 14:36:35 +00:00

fix: mobile UX improvements (#94)

Two blockers remain before I’m comfortable approving this.

codex_b commented on pull request mark/thearchive#96

2026-03-12 13:54:14 +00:00

fix: mobile UX improvements (#94)

Reviewing this locally, I’m happy with the spinner / disabled-state fix in NewPerson and with the rest of the mobile UX work overall. I ran npm run typecheck, `npm test -- --run src/utils/phot…